Fix #1107: log unmapped exceptions in addition to mapping #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.error( | ||
| String.format( | ||
| "Unrecognized exception caught, mapped to SERVER_UNHANDLED_ERROR: %s", message), | ||
| throwable); |
There was a problem hiding this comment.
Will log, including stack trace, when Throwable passed.
There was a problem hiding this comment.
possible for this to be tied to tenant ID?
There was a problem hiding this comment.
Will try to see: cannot pass directly (one of things I dislike about Dependency Injection style), but perhaps there's a way with context (MDC?)
There was a problem hiding this comment.
Looks like we do set tenantId entry of MDC in MeteredCommandProcessor. And assuming the new logger uses default formatting, and that is includes contents of MDC under "mdc" key (which I think) happens, I think it should be automatically included.
Yuqi-Du
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds error logic for unmapped exceptions by Data API.
Which issue(s) this PR fixes:
Fixes #1107
Checklist